docker image lycheeverse/lychee:master doesn't contain latest from master branch?

[trask]

I was trying to test the new --root-dir option, but I get this:

$ docker run lycheeverse/lychee:master --root-dir ...
error: unexpected argument '--root-dir' found

[mre]

Weird. The GitHub workflow passed and the logs say it pushed the images. I can also see them on Dockerhub: https://hub.docker.com/r/lycheeverse/lychee/tags
What does docker inspect give you? Did you pull before? Maybe another pull is necessary?

[trask]

What does docker inspect give you?

It appears to point to the recently published image:

$ docker inspect lycheeverse/lychee:master
[
    {
        "Id": "sha256:a35086dc88f7b664e69a020286eb6b2a6f1c83b673d11595cef734e240dc9414",
        "RepoTags": [
            "lycheeverse/lychee:latest",
            "lycheeverse/lychee:master",
            "lycheeverse/lychee:sha-6d0e94c"
        ],
        "RepoDigests": [
            "lycheeverse/lychee@sha256:a35086dc88f7b664e69a020286eb6b2a6f1c83b673d11595cef734e240dc9414",
            "lycheeverse/lychee@sha256:a35086dc88f7b664e69a020286eb6b2a6f1c83b673d11595cef734e240dc9414",
            "lycheeverse/lychee@sha256:a35086dc88f7b664e69a020286eb6b2a6f1c83b673d11595cef734e240dc9414"
        ],
        "Parent": "",
        "Comment": "buildkit.dockerfile.v0",
        "Created": "2024-12-13T13:37:17.225347677Z",
        "DockerVersion": "27.3.1",
        "Author": "",
        "Config": {
            "Hostname": "",
            "Domainname": "",
            "User": "",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" 
            ],
            "Cmd": null,
            "Image": "",
            "Volumes": null,
            "WorkingDir": "",
            "Entrypoint": [
                "/usr/local/bin/lychee"
            ],
            "OnBuild": null,
            "Labels": {
                "org.opencontainers.image.created": "2024-12-13T13:36:52.234Z",     
                "org.opencontainers.image.description": "⚡ Fast, async, stream-basee
d link checker written in Rust. Finds broken URLs and mail addresses inside Markdown, HTML, reStructuredText, websites and more!",
                "org.opencontainers.image.licenses": "Apache-2.0",
                "org.opencontainers.image.revision": "6d0e94c799db948a94e4916ada154f4e71b0903f",
                "org.opencontainers.image.source": "https://github.com/lycheeverse/lychee",
                "org.opencontainers.image.title": "lychee",
                "org.opencontainers.image.url": "https://github.com/lycheeverse/lychee",
                "org.opencontainers.image.version": "master"
            }
        },
        "Architecture": "amd64",
        "Os": "linux",
        "Size": 41216513,
        "GraphDriver": {
            "Data": null,
            "Name": "overlayfs"
        },
        "RootFS": {
            "Type": "layers",
            "Layers": [
                "sha256:c0f1022b22a9b36851b358f44e5475e39d166e71a8073cf53c894a299239b1c5",
                "sha256:61f5ee50bc505e7d46128d07396fa4df6502c5bf88f78670076185f30a237c73",
                "sha256:4702f5697592d26955dbb76fb6a31dfdf76a66b060feb484630525cc3c8557af"
            ]
        },
        "Metadata": {
            "LastTagTime": "2024-12-13T19:40:49.346603191Z"
        }
    }
]

[trask]

ah, it looks like the Docker build always downloads and uses the latest release:

lychee/Dockerfile-CI.Dockerfile

Line 12 in 6d0e94c

wget -q -O - https://github.com/lycheeverse/lychee/releases/latest/download/lychee-x86_64-unknown-linux-gnu.tar.gz | tar -xz lychee \

[mre]

Okay, we should change that. The easiest way would be to check if we're on the master branch inside the Dockerfile and then downloading the nightly build instead. Not the cleanest approach, but I guess it would work.
Maybe we could control that with build variable.

ARG LYCHEE_VERSION="latest"

Then we can overwrite it:

docker build --build-arg LYCHEE_VERSION=nightly -f Dockerfile-CI.Dockerfile

Open for suggestions here.
@trask, what do you think? Want to take a stab at it if you have the time?

[trask]

oh yes, that sounds straight forward, I will give it a try