Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more details when an ERROR happens #1569

Closed
alessio-locatelli opened this issue Nov 18, 2024 · 3 comments
Closed

Expose more details when an ERROR happens #1569

alessio-locatelli opened this issue Nov 18, 2024 · 3 comments

Comments

@alessio-locatelli
Copy link

alessio-locatelli commented Nov 18, 2024

Version

lycheeverse/lychee:sha-18d486d-alpine@sha256:bb2a23d44ac713aaeea3def850dc6a2b2c57ba6dfba7f730c0088f670916345a

Command example

lychee --exclude-path docs/broken.md --accept '200..=204,403,429,500,503' -vv 'docs/**/*.md' '**/*.yaml' '*.toml'

Problem

The log says "Find details below"... but all the details is the ERROR word. It is difficult for a user to debug what has happened here.

   [ERROR] https://www.privacyguides.org/en/news-aggregators/
Issues found in 1 input. Find details below.
[docs/tutorial.md]:
   [ERROR] https://www.privacyguides.org/en/news-aggregators/
🔍 357 Total (in 9s) ✅ 354 OK 🚫 1 Error

ERROR: Job failed: command terminated with exit code 2

Expected behavior

Log the full traceback or a network error, not just the ERROR word.

@mre
Copy link
Member

mre commented Nov 18, 2024

This should be fixed in master with #1553. It will be released in 0.17.1 when this gets merged: #1554.
In the meantime, can you try the latest master build and see if that resolves the issue?

@alessio-locatelli
Copy link
Author

This should be fixed in master with #1553. It will be released in 0.17.1 when this gets merged: #1554.

Sorry, I checked the issues, but not recently merged pull requests.

In the meantime, can you try the latest master build and see if that resolves the issue?

To be honest, I have no idea how to reproduce the error, as there were no details in the log, so I can only guess at what could go wrong. For example, the URL I show here was working, but lychee just said ERROR and I cannot know why.

Thank you for your reply. I will re-open the issue if I get this problem again after 0.17.1.

@mre
Copy link
Member

mre commented Nov 18, 2024

Here's some sample output with the latest lychee on privacyguides.org:

[docs/email.md]:
   [ERROR] https://tuta.com/support#encrypted-address-book | Network error: error sending request for url (https://tuta.com/support#encrypted-address-book) Maybe a certificate error?
 [TIMEOUT] https://tuta.com/support/#pgp | Timeout

So the error is printed again, just like in the past. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants