Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreML: Loop support #1203

Closed
Vaida12345 opened this issue Dec 12, 2023 · 5 comments
Closed

CoreML: Loop support #1203

Vaida12345 opened this issue Dec 12, 2023 · 5 comments
Assignees
Labels

Comments

@Vaida12345
Copy link

Hey. Just wondering if you could add the support for bodyNetwork of CoreML. Currently, it is like this:
Screenshot 2023-12-12 at 11 23 36 AM
The layers should be linked together (I have checked this using protobuf), but it is not shown here, as the bodyNetworks are not drawn.
It would be great if you can add support for this! Thank you in advance.

@lutzroeder
Copy link
Owner

@Vaida12345 can you share a sample file to reproduce this issue.

@lutzroeder lutzroeder closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
@Vaida12345
Copy link
Author

FrameGRUModel.mlpackage.zip
Sure. Have a look at this package.

@lutzroeder lutzroeder changed the title Support CoreML loop bodyNetwork CoreML: Loop support Dec 12, 2023
@lutzroeder lutzroeder reopened this Dec 12, 2023
lutzroeder added a commit that referenced this issue Dec 13, 2023
lutzroeder added a commit that referenced this issue Dec 13, 2023
lutzroeder added a commit that referenced this issue Dec 13, 2023
lutzroeder added a commit that referenced this issue Dec 13, 2023
@Vaida12345
Copy link
Author

Thank you for your implementation in version 7.3.4.
If I may, can I request another feature please?

In this example,
Screenshot 2023-12-17 at 5 52 44 PM
The copy in blue is an input to the loop in green. Can you add an arrow to link these two please, as the one in orange?

Thank you again for accepting my feature request. You can use the same model I sent before.

@lutzroeder
Copy link
Owner

@Vaida12345 see #1204. Can you help implement this and submit a pull request that works for all formats.

@Vaida12345
Copy link
Author

I would love to, but I really don't know how. Javascript is not where I shine. If you give me an outline, I might be able to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants