Fix/call response modifier plugin 597 #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfpferreira
force-pushed
the
fix/call-response-modifier-plugin-597
branch
2 times, most recently
from
d001e61 to
216025a
Compare
danielfpferreira
changed the title
danielfpferreira
changed the title
Signed-off-by: Daniel Ferreira <[email protected]>
Allows merged response from multible backends to be modified if at least one of the backends replied, resp is not nil and the error would be for instance a mergeErr. Signed-off-by: Daniel Ferreira <[email protected]>
danielfpferreira
force-pushed
the
fix/call-response-modifier-plugin-597
branch
from
216025a to
f095e8e
Compare
|
This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #597
Check if next proxy resp is nil when returning early when there's an error
If resp is not nil, for instance when we have a merged response and a mergeError with at least one of the backends returning a response we would still want to call a response modifier for that response.
Fixed a couple of typos