Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slash on SPA route #65

Open
SidKH opened this issue Dec 15, 2020 · 2 comments
Open

Trailing slash on SPA route #65

SidKH opened this issue Dec 15, 2020 · 2 comments

Comments

@SidKH
Copy link

SidKH commented Dec 15, 2020

Hey.
I'm using Servor to serve an SPA with create-react-app
The problem is - whenever my SPA route ends with a slash I have 404.

For example, let's say I'm serving my app from https://myapp.com, and I have a react route /hello-world.
This URL works fine https://myapp.com/hello-world
But this one gives me 404 https://myapp.com/hello-world/

@lukejacksonn
Copy link
Owner

Thanks for the report and sorry for the late reply I have been busy with some other projects. I'm not sure why servor doesn't strip trailing slashes.. would have to go check the code but I don't imagine it would be a massive pain to implement.

I've been meaning to address all the PRs on this repo for a while. If you find a fix feel free to make a pull request and I will address it with the others.

@JacopoBonta
Copy link

Thanks for the report and sorry for the late reply I have been busy with some other projects. I'm not sure why servor doesn't strip trailing slashes.. would have to go check the code but I don't imagine it would be a massive pain to implement.

I've been meaning to address all the PRs on this repo for a while. If you find a fix feel free to make a pull request and I will address it with the others.

Hi, I was about to start the fix on my own but then found this #82 Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants