Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox spuriously fallbacks to it's own notifications #8

Open
VixieTSQ opened this issue Feb 3, 2024 · 6 comments
Open

Firefox spuriously fallbacks to it's own notifications #8

VixieTSQ opened this issue Feb 3, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@VixieTSQ
Copy link
Contributor

VixieTSQ commented Feb 3, 2024

I have it so when I click on my notification in eww, it'll call end close <id>. But when the timeout for the notification is up and end tries to close it, it fails and crashes because the notification is already closed

@VixieTSQ
Copy link
Contributor Author

VixieTSQ commented Feb 3, 2024

Or sorry, not a crash. But it makes firefox think it crashed because it sends an error back to it over DBus (my educated guess). So firefox starts using it's own notification popups again.

@lucalabs-de
Copy link
Owner

Interesting. The closing after the timeout is implemented as a filter over the list of notifications, so if a notification was already closed/removed before, it should be a no-op. But we currently don't send the NotificationClosed signal; maybe that causes issues in some cases. On the other hand, when notifications simply time out, it seems to work even without the signal.

It's late here, I will try to reproduce this tomorrow.

@lucalabs-de lucalabs-de added the bug Something isn't working label Feb 4, 2024
@lucalabs-de
Copy link
Owner

I cannot reproduce this by closing notifications manually. However, it seems that sometimes Firefox notices when I restart end to apply changes and then falls back to its own notifications. Restarting Firefox while end is running fixes this. Is this maybe what happened in your case as well?

@VixieTSQ
Copy link
Contributor Author

VixieTSQ commented Feb 4, 2024

I cannot reproduce this by closing notifications manually. However, it seems that sometimes Firefox notices when I restart end to apply changes and then falls back to its own notifications. Restarting Firefox while end is running fixes this. Is this maybe what happened in your case as well?

Very odd. Now I can't reproduce it either. I will keep this open for bit while I observe to see when firefox breaks.

@VixieTSQ
Copy link
Contributor Author

VixieTSQ commented Feb 5, 2024

I cannot reproduce this by closing notifications manually. However, it seems that sometimes Firefox notices when I restart end to apply changes and then falls back to its own notifications. Restarting Firefox while end is running fixes this. Is this maybe what happened in your case as well?

It's still definitely happening, I just can't say why. It does happen even when I'm not messing around with end. And end doesn't even print anything when firefox stops liking it. I'm stumped

@VixieTSQ VixieTSQ changed the title Fix spurious crashes on prematurely closed notifications. Firefox spuriously fallbacks to it's own notifications Feb 7, 2024
@lucalabs-de
Copy link
Owner

Maybe this is related to all the missing signals we're not sending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants