Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe i find a point should be change #12

Open
alphanlp opened this issue Dec 4, 2018 · 2 comments
Open

maybe i find a point should be change #12

alphanlp opened this issue Dec 4, 2018 · 2 comments

Comments

@alphanlp
Copy link

alphanlp commented Dec 4, 2018

self.target_layer = TimeDistributed(Dense(o_tokens.num(), use_bias=False))
change to:
self.target_layer = TimeDistributed(Dense(o_tokens.num(), activation='softmax', use_bias=False))

@alphanlp
Copy link
Author

alphanlp commented Dec 5, 2018

it's very interesting, when i user softmax as proposed in paper, the loss can not down

@lsdefine
Copy link
Owner

lsdefine commented Dec 5, 2018

The tf loss contains a softmax. In fact, you do softmax twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants