Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #198, adds param to support removing inaccessible databases #199

Merged
merged 2 commits into from
Aug 26, 2023
Merged

Fixes #198, adds param to support removing inaccessible databases #199

merged 2 commits into from
Aug 26, 2023

Conversation

git-cgallagher
Copy link
Contributor

@git-cgallagher git-cgallagher commented Aug 23, 2023

Description

Adds only_accessible parameter to module to support removing orphaned database on availability group replica.

How Has This Been Tested?

Local testing

Types of changes

Checklist:

@git-cgallagher git-cgallagher changed the title Fixes lowlydba/lowlydba.sqlserver#198, adds param to support removing inaccessible databases Fixes #198, adds param to support removing inaccessible databases Aug 23, 2023
@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://lowlydba.github.io/lowlydba.sqlserver/branch/main

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9a5a958) 93.80% compared to head (c616ff6) 93.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   93.80%   93.81%           
=======================================
  Files          64       64           
  Lines        2196     2198    +2     
=======================================
+ Hits         2060     2062    +2     
  Misses        136      136           
Flag Coverage Δ
sanity 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/modules/database.py 100.00% <ø> (ø)
plugins/modules/database.ps1 85.10% <100.00%> (+0.21%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lowlydba
Copy link
Owner

Thank you for the contribution! Looks great.

@lowlydba lowlydba merged commit 5632e02 into lowlydba:main Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants