Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RACL] Improve error checking when parsing a RACL config #25690

Open
Razer6 opened this issue Dec 18, 2024 · 0 comments
Open

[RACL] Improve error checking when parsing a RACL config #25690

Razer6 opened this issue Dec 18, 2024 · 0 comments
Assignees

Comments

@Razer6
Copy link
Member

Razer6 commented Dec 18, 2024

#25664 adds the initial part of the RACL implementation. This confidently parses the RACL config without much error checking. This should be improved over time but should allow the functional implementation to continue.

          I'd strongly suggest putting a tiny bit more type checking in here. Something like extracting `roles` and `policies` as a list / dictionary, respectively (doing a basic type check) and maybe checking the item and key/value types for them respectively.

Extracting that properly will get rid of the dictionary lookups lower down in the function.

Originally posted by @rswarbrick in #25664 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant