Reuse Patron session with mutex #1002
Conversation
Reuse Patron session to support keep-alive/connection reuse and make them thread-safe using a mutex. fixes #1001
derSascha
force-pushed
the
patron-thread-safe-session-reuse
branch
from
68b8949
to
67477d6
Compare
There was a problem hiding this comment.
The PR itself makes sense, although the new test added doesn't really test anything (if I understand the PR correctly). You can also ignore the CodeClimate issues as those were not addressed with call to begin with.
However, even if the test is fixed based on my comment, I'd still like to get to a resolution on #1001 before progressing with this.
| conn = Faraday.new do |f| | ||
| f.adapter :patron do |session| | ||
| if last_session | ||
| expect(session).to eq last_session |
There was a problem hiding this comment.
Given @config_block&.call(session) will be called only once due to the cache, I wouldn't expect this expect to ever be executed.
Instead, you could use a variable to check that this block is only called once:
config_calls = 0
conn = Faraday.new do |f|
f.adapter :patron do |session|
config_calls += 1
end
endand then after the two conn.get('http://example.com/') you can
expect(config_calls).to eq(1)
|
@derSascha I really appreciate you taking a stab at this, however as the discussion in #1001 shows, this is not the solution we'd like to go with, so I'm closing this PR. I'll do my best to help agreeing and implementing a solution. |
Reuse Patron session to support keep-alive/connection reuse and make
them thread-safe using a mutex.
Description
This reverts the changes from PR #796 and reuse the patron session for keep-alive/connection reuse. To be thread safe, this adds a mutex around the patron session. See persisted connections and Threads in the patron documentation for more details.
Fixes #1001
Todos