From f1a68274e9e6509718882aef259d57e137691b84 Mon Sep 17 00:00:00 2001 From: 8naama Date: Mon, 1 Jul 2024 11:53:54 +0300 Subject: [PATCH] fixes following code review --- .github/workflows/tests.yaml | 10 ++++++++-- eventbridge-lambda/handler/handler.go | 2 +- eventbridge-lambda/handler/handler_test.go | 2 +- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 62e9591..3447abd 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -1,5 +1,10 @@ name: Unit and E2E Tests -on: [pull_request] +on: + pull_request: + schedule: + # Run once a week on Sunday + - cron: "0 7 * * 0" + jobs: #### Unit tests #### @@ -31,7 +36,7 @@ jobs: runs-on: ubuntu-latest env: AWS_REGION: 'us-east-1' - TEST_VERSION: 0.0.7357 + TEST_VERSION: test steps: # Initialize env - uses: actions/checkout@v4 @@ -134,6 +139,7 @@ jobs: # Cleanup - name: Delete Stack + if: always() run: | aws cloudformation delete-stack \ --stack-name auto-test-firehose-log diff --git a/eventbridge-lambda/handler/handler.go b/eventbridge-lambda/handler/handler.go index 99b9f7d..9667728 100644 --- a/eventbridge-lambda/handler/handler.go +++ b/eventbridge-lambda/handler/handler.go @@ -1,4 +1,4 @@ -package handelr +package handler import ( "context" diff --git a/eventbridge-lambda/handler/handler_test.go b/eventbridge-lambda/handler/handler_test.go index 21f7d61..2647722 100644 --- a/eventbridge-lambda/handler/handler_test.go +++ b/eventbridge-lambda/handler/handler_test.go @@ -1,4 +1,4 @@ -package handelr +package handler import ( "context"