simple-client sample seems broken #324
Comments
|
I think I noticed this at one point and found it only happens with this server SDK, so I wonder if it's a change in the client exposing a bug in the server, or it may be a bug in the client. I'll look into it when I find some time. |
|
I think it would be worthwhile to implement integration tests against the examples. @locka99 answered a few days ago; he's currently pretty busy and it might take a moment until he gets back to this project. |
|
Alright. Whatever this is, it doesn't happen when running the client against other servers, or at all in my rewrite of the server part of the SDK (which finally runs the sample server now...). From what I can tell the sample server is supposed to publish on v3 and v4 as well, (at least it does now...) so there is more wrong here. I wonder if maybe this is caused by a deadlock in the sampling logic? Perhaps triggered by the client now being able to send requests in parallel? |
|
I'll see to verifying that tomorrow. Maybe I'll get that finding into the pipeline as well. |
|
Thanks for having looked into it that fast! |
Aas it's currently not working for at least two different reasons: Commit(43afb6a): 'Implement JSON serialization on most built-in data types.', which broke the JS parsing and updating of subscribed values. And the other being Commit(eab4caa): 'Rewrite the client to be async all the way through', which indirectly halted subscriptions for servers implemented with this crate (locka99#324). Re-adding this sample would be highly appreciated. If possible with tests, which might prevent its recurring decay.
as it's currently not working for at least two different reasons: Commit(43afb6a): 'Implement JSON serialization on most built-in data types.', which broke the JS parsing and updating of subscribed values. And the other being Commit(eab4caa): 'Rewrite the client to be async all the way through', which indirectly halted subscriptions for servers implemented with this crate (locka99#324). Re-adding this sample would be highly appreciated. If possible with tests, which might prevent its recurring decay.
as it's currently not working for at least two different reasons: Commit(43afb6a): 'Implement JSON serialization on most built-in data types.', which broke the JS parsing and updating of subscribed values. And the other being Commit(eab4caa): 'Rewrite the client to be async all the way through', which indirectly halted subscriptions for servers implemented with this crate (locka99#324). Re-adding this sample would be highly appreciated. If possible with tests, which might prevent its recurring decay.
as it's currently not working for at least two different reasons: Commit(43afb6a): 'Implement JSON serialization on most built-in data types.', which broke the JS parsing and updating of subscribed values. And the other being Commit(eab4caa): 'Rewrite the client to be async all the way through', which indirectly halted subscriptions for servers implemented with this crate (locka99#324). Re-adding this sample would be highly appreciated. If possible with tests, which might prevent its recurring decay.
as it's currently not working for at least two different reasons: Commit(43afb6a): 'Implement JSON serialization on most built-in data types.', which broke the JS parsing and updating of subscribed values. And the other being Commit(eab4caa): 'Rewrite the client to be async all the way through', which indirectly halted subscriptions for servers implemented with this crate (locka99#324). Re-adding this sample would be highly appreciated. If possible with tests, which might prevent its recurring decay.
As the simple-server sample only publishes v1 and v2, the client is subscribed to v1,v2,v3,v4 and does not receive updates for v3,v4 and does nothing after the first update.
After changing the client to only subscribe to v1,v2 it behaves as expected and receives updates from the server.
The text was updated successfully, but these errors were encountered: