Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

Custom Login #45

Open
TKlerx opened this issue Jan 19, 2015 · 11 comments
Open

Custom Login #45

TKlerx opened this issue Jan 19, 2015 · 11 comments
Labels

Comments

@TKlerx
Copy link

TKlerx commented Jan 19, 2015

Is there any possibility to use a simple Login Provider when jukebox has no online access?
I would like to use this application at a party where every user should just login and nobody has internet access.

@lociii
Copy link
Owner

lociii commented Jan 19, 2015

Right now it's not possible. I'm working on an updated version of jukebox but my time for this project is very limited. Feel free to fork the project and add the feature yourself. Pull requests are always welcome.

@TKlerx
Copy link
Author

TKlerx commented Jan 19, 2015

Thanks for the quick reply. Ok, I will try that but I am not that deep into django and how it works.

@TKlerx
Copy link
Author

TKlerx commented Jan 21, 2015

Got it working, but I think it is not ready to be pulled. I will try to do so when I have free time. If you wish I can send you my ugly changes.

@lociii
Copy link
Owner

lociii commented Jan 24, 2015

Would you mind forking the project on github and check in your changes? I'd like to have a look at them.

@lociii lociii added the Feature label Jan 24, 2015
@TKlerx
Copy link
Author

TKlerx commented Jan 26, 2015

I already forked the project but I realized that some of the changes are on a machine I have no access to right now. I'll try to do it tomorrow and let you know. Had to destroy the localization, though.

EDIT: I have some other Feature Requests. Shall I just add them here or shall we discuss them somehow/somewhere else?

@TKlerx
Copy link
Author

TKlerx commented Jan 28, 2015

Ok, I pushed the changes to my repo. You can have a look.

@nermolov
Copy link

How can I use it?

@TKlerx
Copy link
Author

TKlerx commented May 13, 2015

Did you have a look at my fork?
It works just with a simple local database storing the logins and hashed passwords of everyone who registered.

@lociii
Copy link
Owner

lociii commented Jun 27, 2015

Finally I found the time to look at your fork.
Looks nice but should be made optional. Maybe add a setting JUKEBOX_ALLOW_LOCAL_AUTH?
Registration and local login should be disabled if the setting is set to False.

@TKlerx
Copy link
Author

TKlerx commented Jun 29, 2015

Nice that you found the time.
It is true, the local login should be made optional. It should also be possible to create the accounts in advance and then disable the registration feature.
It was a somehow dirty hack when I needed it.
I found many other things that could be integrated into jukebox, but I am neither a good web developer in general nor a good django/python developer.

@lociii
Copy link
Owner

lociii commented Jul 3, 2015

Unfortunately, I currently don't spend time to further develop the jukebox system. Things have changed since I first released this software almost four years ago. Most people don't even own mp3 anymore. Streaming is the future. There are systems like http://qca.st/ that may replace this tool.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants