Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Correct melting and boiling points for Carbon allotropes #214

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[FIX] Correct melting and boiling points for Carbon allotropes #214

wants to merge 4 commits into from

Conversation

lmmentel
Copy link
Owner

@lmmentel lmmentel commented Dec 22, 2024 •
edited
Loading

Fixes #212

Proposed Changes

  • Drop melting points from PhaseTransition for carbon allotropes (graphite and diamond) since they are not at starndard pressueres.
  • Add is_sublimation_point to PhaseTransition where boiling point is a sublimation point
  • Add is_transition to PhaseTransition where melting point is a phase transition to the crystalline form.

After the changes

>>> from mendeleev import C
>>> print(C.melting_point)
None
>>> print(C.boiling_point)
4098.15
>>> print(C.phase_transitions)
[PhaseTransition(atomic_number=6, allotrope=graphite, melting_point=None, boiling_point=4098.15, triple_point_temperature=4762.15, triple_point_pressure=10300.0, critical_temperature=None, pritical_pressure=None, is_sublimation_point=True, is_transition=None)]

@lmmentel lmmentel self-assigned this Dec 22, 2024
@lmmentel lmmentel added data Data update bugfix labels Dec 22, 2024
@lmmentel lmmentel mentioned this pull request Dec 22, 2024
Open
@lmmentel lmmentel changed the title [FIX] Correct metling and boiling points for Carbon allotropes [FIX] Correct melting and boiling points for Carbon allotropes Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lmmentel lmmentel

Labels
bugfix data Data update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent presentation of thermophysical properties
1 participant
@lmmentel