Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean-up #18

Open
lmizrahi opened this issue Jun 10, 2024 · 0 comments
Open

clean-up #18

lmizrahi opened this issue Jun 10, 2024 · 0 comments

Comments

@lmizrahi
Copy link
Owner

lmizrahi commented Jun 10, 2024 •
edited
Loading

A few things could be cleaned up/homogenized throughout the repo:

  • in inversion.py: naming of "auxiliary_start", "timewindow_start", etc. could be more intuitively named.
  • in evaluate.py: check the docstring for the likelihood calculation class
  • in inversion.py and evaluate.py: both files define a to_days function, but they are different. hopefully only one is needed and can be used for both.
  • update the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmizrahi