Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect client version automatically #90

Open
OndraM opened this issue Sep 27, 2018 · 0 comments
Open

Detect client version automatically #90

OndraM opened this issue Sep 27, 2018 · 0 comments

Comments

@OndraM
Copy link
Member

OndraM commented Sep 27, 2018

We should replace Matej::VERSION constant, which needs to be updated each release, with https://github.com/Ocramius/PackageVersions , which allows to read the version based on actual package version installed via Composer.

Current way we update the constant manually each release also causes BC break false positive each time the constant value is changed (as it is considered BC break by https://github.com/Roave/BackwardCompatibilityCheck )

However, the PackageVersions requires PHP 7 ¯\_(ツ)_/¯, so we are blocked until we need to support PHP-5 version of Matej client.

@OndraM OndraM changed the title Detect package version automatically Detect client version automatically Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant