Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do I have to provide the 'error' property ? #25

Open
fbeaufume opened this issue Jul 7, 2021 · 0 comments
Open

Why do I have to provide the 'error' property ? #25

fbeaufume opened this issue Jul 7, 2021 · 0 comments

Comments

@fbeaufume
Copy link

Hi. This is a nice component. Thank you for sharing.

I have a concern about the 'error' property. Since I have to provide it, I have to compute myself the boolean using the current selected interval and disabled intervals, otherwise the initial red-or-green color of the component can be wrong.

This feels weird and a bit overly complicated.

Could you compute it inside the component instead ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fbeaufume