Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go get from README gives 'cannot find package "github.com/ethereum/go-ethereum/logger/glog"' #24

Closed
pgorsira opened this issue Apr 11, 2017 · 3 comments

Comments

@pgorsira
Copy link

When running the "fetch and build the livepeer node" step of the Installation section from the README, it errors out:

$ go get github.com/livepeer/go-livepeer/cmd/livepeer
package github.com/ethereum/go-ethereum/logger/glog: cannot find package "github.com/ethereum/go-ethereum/logger/glog" in any of:
	/usr/local/Cellar/go/1.7.5/libexec/src/github.com/ethereum/go-ethereum/logger/glog (from $GOROOT)
	/Users/pgorsira/Projects/go/src/github.com/ethereum/go-ethereum/logger/glog (from $GOPATH)

Appears the cause is go-ethereum switching from glog to log15 about a month ago. You can see that the logger package is no longer available and has been replaced by log.

@pgorsira
Copy link
Author

As a quick fix, I manually cloned https://github.com/livepeer/go-ethereum into my go workspace, moved src/github.com/livepeer/go-ethereum to src/github.com/ethereum/go-ethereum, and re-ran the go get from above. This worked.

I suspect a longer term solution would be to update the logging statements in go-livepeer to use the new log15-based logger that's implemented in the current version of go-ethereum. Does that seem appropriate?

@dob
Copy link
Member

dob commented Apr 11, 2017

Go-ethereum should be vendored in the /vendor dir, so I'm surprised this happened. I'll investigate. Thanks.

@dob
Copy link
Member

dob commented Apr 11, 2017

Fixed via this commit to LPMS:
livepeer/lpms@fed5e0d
It was accidentally referencing go-ethereum/glog when it should have been importing golang/glog. LPMS isn't meant to have any dependencies on ethereum.

@dob dob closed this as completed Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants