Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

Stepping down as a maintainer #257

Open
little-dude opened this issue May 5, 2022 · 22 comments
Open

Stepping down as a maintainer #257

little-dude opened this issue May 5, 2022 · 22 comments

Comments

@little-dude
Copy link
Owner

little-dude commented May 5, 2022

Hello,

Due to a pretty time consuming job and several life projects, I just don't have time to maintain these crates. I've let PRs accumulating for a while now and I'd like to apologize to the people who have been waiting for a review from me.

I'm not sure what to do from now. Are there people willing to take over? Should I create an organization and transfer the repo?

Again, sorry for letting issues and PRs rot for so long. This post was long overdue...

Link to the reddit annoucement

@little-dude little-dude pinned this issue May 5, 2022
@little-dude
Copy link
Owner Author

Ping @benjumanji @JohnTitor @cathay4t since all three of you have crates.io access.

@JohnTitor
Copy link
Collaborator

JohnTitor commented May 5, 2022

I'm not sure what to do from now. Are there people willing to take over? Should I create an organization and transfer the repo?

I'm personally in favor of creating an org, it'll make it easier to manage collaborators and the repo (though I'm not a core collaborator here, I'm open to other collaborator's thoughts).

@wllenyj
Copy link
Contributor

wllenyj commented May 19, 2022

organization +1
Each crate into a separate repo ?
open to other 's thoughts

@JohnTitor
Copy link
Collaborator

Each crate into a separate repo ?

Monorepo has some benefits e.g. being able to upgrade stuff at once, so I'm not sure if it's really necessary 🤔 (we could discuss later)

@little-dude If you're okay to create an org but are busy, I'm happy to do it instead, let me know.

@cathay4t
Copy link
Collaborator

cathay4t commented Oct 3, 2022

organization +1
Each crate into a separate repo +1

@cathay4t
Copy link
Collaborator

cathay4t commented Oct 4, 2022

Since this project is been used by nispor, nmstate and podman-netavark which are all sponsored by Red Hat, I could put some of work hours to maintain this project.

@little-dude
Copy link
Owner Author

organization +1

https://github.com/netlink-rs is taken unfortunately. netlink-rust perhaps?

I could put some of work hours to maintain this project.

Oh that'd be awesome :)

@JohnTitor
Copy link
Collaborator

@netlink-rs is taken unfortunately. netlink-rust perhaps?

👍, either netlink-rust or rust-netlink sounds fine.

@cathay4t
Copy link
Collaborator

cathay4t commented Oct 6, 2022

Please consider split this single project into small parts to simplify the effort of versioning.

@cathay4t
Copy link
Collaborator

cathay4t commented Oct 7, 2022

I have created https://github.com/rust-netlink and @benjumanji @JohnTitor @little-dude are invited as owner.

Currently, I have imported the full git repo there. I am doing split up in the meantime which might take a while.

@cathay4t
Copy link
Collaborator

cathay4t commented Oct 7, 2022

Repo split with commit history preserved done.

All sub-repo has CI enabled and passing.

@cathay4t
Copy link
Collaborator

cathay4t commented Oct 8, 2022

The next steps:

  • Request pending PRs to move to new places. Close if not respond after 1 month.
  • Change README.md file to redirecting user to new places.
  • Put this project into archiev mode.

@cathay4t
Copy link
Collaborator

cathay4t commented Oct 8, 2022

I have to admit I changed the max_width from 100 to 80 in all repos when I enable and fixing CI.
The 80 allows me to open two buffer windows in vim and that improve my daily code work speed.

@wllenyj
Copy link
Contributor

wllenyj commented Oct 9, 2022

I'd love to maintain rust-netlink together, I am the dbs's maintainer. And also improved version problem in the rust-vmm crate, e.g. rust-vmm/vm-memory#199.
We rely heavily on netlink-rs crate in kata-containers.

In netlink-rs, I mainly implemented the tc feature.

@cathay4t
Copy link
Collaborator

@wllenyj I have invited you into rust-netlink organization with rw right considering you have 4 patches merged. Thanks for the interest on https://github.com/rust-netlink

@Tuetuopay
Copy link
Contributor

Tuetuopay commented Oct 12, 2022

Heh this happens right when I opened a PR for a long-standing issue on the core netlink socket handling (the ENOBUFS thingy). I'll reopen it against the proper repo!

EDIT: oh god that PR will transform in 10 PRs due to the split 🤣

@cathay4t
Copy link
Collaborator

@Tuetuopay Sorry for the extra work, but I believe isolate crates is better than bloated project. Thanks for the efforts.

@cathay4t
Copy link
Collaborator

@Tuetuopay And IMHO, reexport is wrong. If you don't have use case require so, you don't need to follow that old habit.

@Tuetuopay
Copy link
Contributor

Oh ok, well, that reduces the PR count. Thanks :)

@wllenyj
Copy link
Contributor

wllenyj commented Oct 13, 2022

@cathay4t @little-dude @JohnTitor Do we have a repo or slack for public discussion to? I want to create code coverage support for netlink, but don't know where to post the Proposal.

@cathay4t
Copy link
Collaborator

@wllenyj Github issue could be a good place for disucssion. You may use https://github.com/rust-netlink/.github/issues if that topic is related to general design. In case anyone want instant feedback, I am on IRC libra #rust-netlink channel.

@cathay4t
Copy link
Collaborator

rust-netlink/.github#1 create to track the efforts on removing reexport.
rust-netlink/.github#2 created for test code coverage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants