Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix maven-settings-xml-action for PRs from outside the repo #80

Open
rursprung opened this issue Nov 22, 2024 · 2 comments
Open

CI: fix maven-settings-xml-action for PRs from outside the repo #80

rursprung opened this issue Nov 22, 2024 · 2 comments
Assignees

Comments

@rursprung
Copy link
Collaborator

whenever a PR does not originate from a branch within this repo the CI fails:

Run whelk-io/maven-settings-xml-action@v21
[xmldom error]	invalid doc source 
@#[line:0,col:undefined]
Error: Cannot read properties of undefined (reading 'nodeType')

accordingly the tests are not being executed. this has never worked in this repo and needs to be fixed.

@filipelautert
Copy link
Contributor

Hey @rursprung this a security measure: if we ran tests from any repo PR our secrets may be exposed by malicious code by unknow people. That's why we only run test from trusted contributors that have commit access like you, and for the other ones we need to "Approve" before running them.

@rursprung
Copy link
Collaborator Author

but it crashes instead of just waiting for approval (there's a dedicated approval step) - so i still think this is a bug.
if you check e.g. this workflow run you can see that it passed the "authorize" step.

also, this has always crashed, even when you approved it.

there are also some built-in measures in GitHub to deal with action runs for outside contributors, see their docs. this might be a better approach than just crashing the script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants