Fix issue #278: add compliancemode parameter in JDBC URL if absent

[maximevw]

This closes #278

This adds a CassandraDatabaseConnection implementation for DatabaseConnection interface, extending JdbcConnection. In this implementation, the compliance mode parameter Liquibase is added to the JDBC URL if necessary when the used JDBC driver is com.ing.data.cassandra.jdbc.CassandraDriver.

[MalloD12]

Hey @maximevw,

It seems the unit tests you added on this PR are failing because it cannot find CassandraDatabaseConnection. See below:

Error:  liquibase.ext.cassandra.database.CassandraDatabaseConnectionTest.open with jdbc:cassandra://localhost:9042/betterbotz?compliancemode=Liquibase&localdatacenter=datacenter1 -- Time elapsed: 0.010 s <<< ERROR!
java.lang.NoClassDefFoundError: liquibase/ext/cassandra/database/CassandraDatabaseConnection

Same for the other scenario. Would you mind having a look?

Thanks,
Daniel.

[maximevw]

Hello @MalloD12,

Running the command mvn -B test -P 'coverage' (the same as in the failed pipeline) locally gives me a build success and all tests pass:

...
[INFO] Running liquibase.ext.cassandra.database.CassandraDatabaseConnectionTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.904 s -- in liquibase.ext.cassandra.database.CassandraDatabaseConnectionTest
[INFO] liquibase.ext.cassandra.database.CassandraDatabaseConnectionTest.open with jdbc:cassandra://localhost:9042/betterbotz?compliancemode=Liquibase&localdatacenter=datacenter1 -- Time elapsed: 0.833 s
[INFO] liquibase.ext.cassandra.database.CassandraDatabaseConnectionTest.open with jdbc:cassandra://localhost:9042/betterbotz?localdatacenter=datacenter1 -- Time elapsed: 0.002 s
[INFO] liquibase.ext.cassandra.database.CassandraDatabaseConnectionTest.open with jdbc:cassandra://localhost:9042/betterbotz -- Time elapsed: 0.002 s
[INFO] liquibase.ext.cassandra.database.CassandraDatabaseConnectionTest.open with #url -- Time elapsed: 0.852 s
[INFO] Running liquibase.ext.cassandra.MysqlCompatibilityCheckTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.705 s -- in liquibase.ext.cassandra.MysqlCompatibilityCheckTest
[INFO] liquibase.ext.cassandra.MysqlCompatibilityCheckTest.Liquibase should continue to work with Mysql when Cassandra Extension is in classpath -- Time elapsed: 1.684 s
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- jacoco-maven-plugin:0.8.11:report (report) @ liquibase-cassandra ---
[INFO] Loading execution data file /home/maxime/dev/liquibase-cassandra/target/jacoco.exec
[INFO] Analyzed bundle 'Liquibase Extension: Cassandra Database Support' with 21 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

But, I found these differences:

On GitHub - test step:

[INFO] --- resources:3.3.1:resources (default-resources) @ liquibase-cassandra ---
[INFO] Copying 6 resources from src/main/resources to target/classes

[INFO] --- compiler:3.11.0:compile (default-compile) @ liquibase-cassandra ---
[INFO] Changes detected - recompiling the module! :input tree
[INFO] Compiling 20 source files with javac [debug deprecation target 1.8] to target/classes

...

[INFO] --- gplus:3.0.2:compileTests (default) @ liquibase-cassandra ---
[INFO] Using isolated classloader, without GMavenPlus classpath.
[INFO] Using Groovy 4.0.20 to perform compileTests.
[INFO] invokedynamic enabled.
[INFO] Parallel parsing enabled.
[INFO] Compiled 8 files.

In my local environment and on GitHub - build and package step:

[INFO] --- maven-resources-plugin:3.3.1:resources (default-resources) @ liquibase-cassandra ---
[INFO] Copying 7 resources from src/main/resources to target/classes

[INFO] --- compiler:3.11.0:compile (default-compile) @ liquibase-cassandra ---
[INFO] Changes detected - recompiling the module! :source
[INFO] Compiling 21 source files with javac [debug deprecation target 1.8] to target/classes

...

[INFO] --- gmavenplus-plugin:3.0.2:compileTests (default) @ liquibase-cassandra ---
[INFO] Using isolated classloader, without GMavenPlus classpath.
[INFO] Using Groovy 4.0.20 to perform compileTests.
[INFO] invokedynamic enabled.
[INFO] Parallel parsing enabled.
[INFO] Compiled 10 files.

The differences in the number of compiled files come from the files added by this PR.
But, I guess it's not really relevant because the test pipeline checks out the main branch then copies the content of target folder previously built from the branch to merge.

So, I don't really understand why the CassandraDatabaseConnection class is missing in the classpath when running tests here.

Do you prefer I skip the added test for now? Or there is something in particular to do when adding new tests in this project?

[MalloD12]

@filipelautert @sayaliM0412: I know that discrepancy with the compiled (GH vs Local) files Maxime is showing us could be for different reasons, but is there anything you guys can suggest to try?

@maximevw: I will generally recommend moving forward with a PR by adding some unit tests as you already provided.

Thanks,
Daniel.

[maximevw]

Additional question: is there a reason to re-build the main branch before running tests in the steps "Test - Java xx" instead of just running tests with the classes copied to the target folder from the step "Build & package" (containing the missing class only present in the branch to merge)?
This might explain the observed difference, although this seems unlikely.

[shubha11m]

can anyone please help to connect aws keypace and creeate table using liquibase in springbooot project

[maximevw]

can anyone please help to connect aws keypace and creeate table using liquibase in springbooot project

Hello @shubha11m,
Regarding AWS Keyspaces, there is currently an open issue about it: #297
For integration with Spring Boot, please take a look at: #212

Also please create separate issues in case of questions. This will avoid polluting unrelated topics like here. 🙏🏻

[MalloD12]

Hi @maximevw,

I just want to let you know the team has found a build issue in one of our workflow configurations. We have created an internal ticket for that. I'll leave this PR on hold until that issue is fixed so then we can see a clean build run on this PR.

Thanks,
Daniel.

[maximevw]

@MalloD12 thank you for the feedback.
I assume this one could fix the issue: liquibase/build-logic#210 😄

[MalloD12]

Nice, good finding @maximevw!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[maximevw]

@MalloD12 Good news! The build is fixed and all the tests pass now 🙂

[MalloD12]

Approved.

Thank you @maximevw!

[filipelautert]

Usually we do CONSTANT + increment, but we can fix it later.

[maximevw]

Thanks for the recommandation @filipelautert: I didn't know how was fixed this value, so I took a value for which I was almost sure the CassandraDatabaseConnection will be used. I can fix that in a separate PR, as you suggested; do you have an example of the good way to do that?

[filipelautert]

@maximevw at liquibase-core we have PRIORITY_DATABASE + 5, like in https://github.com/liquibase/liquibase/blob/53db8b6d12a9db371bbcd620f99aca954d3bbbfd/liquibase-standard/src/main/java/liquibase/database/core/EnterpriseDBDatabase.java#L46 . But could be +200, no problems!