Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin Utils: Validate Address should succeed for proper p2sh-segwit addresses #429

Open
matthewjablack opened this issue Jul 8, 2021 · 1 comment
Open

Bitcoin Utils: Validate Address should succeed for proper p2sh-segwit addresses #429

matthewjablack opened this issue Jul 8, 2021 · 1 comment

Comments

@matthewjablack
Copy link
Contributor

matthewjablack commented Jul 8, 2021 •
edited
Loading

Currently validateAddress fails for p2sh-segwit addresses in bitcoin-utils.

One would expect these types of addresses to succeed for all types of addresses... legacy, p2sh-segwit, segwit.

If this function is specifically to be used for validating swap addresses, then it should probably be renamed to validateSwapAddress.
@kraikov
Copy link
Collaborator

kraikov commented May 12, 2022

@monokh any actions here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewjablack @kraikov