Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/ratings: hide accessible text for rating buttons to only be visible for screen readers #1728

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Dec 11, 2024

this fixes an error with the new rating buttons that causes the screen reader text to be visible

@vellip vellip requested review from goapunk and hom3mad3 December 11, 2024 09:51
@vellip
Copy link
Collaborator Author

vellip commented Dec 11, 2024

see liqd/a4-meinberlin#5876

@vellip vellip force-pushed the pv-2024-12-hide-rating-text branch from f9f7ab2 to b2574db Compare December 11, 2024 09:55
@hom3mad3 hom3mad3 merged commit eb93915 into main Dec 11, 2024
5 checks passed
@hom3mad3 hom3mad3 deleted the pv-2024-12-hide-rating-text branch December 11, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants