Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Abstract the commandline options for the command used for kdump_core_collector #19

Open
tyll opened this issue Oct 11, 2018 · 1 comment

Comments

@tyll
Copy link
Member

tyll commented Oct 11, 2018

Currently the kdump_core_collector accepts values such as makedumpfile -l --message-level 2 -d 30 that we demo in presentations. Since the system roles are also about abstractions, it would make sense to expose the command-line options for makedumpfile as individual variables, especially the bitmap specified after -d could be exposed as the following booleans:

  • kdump_dump_zero_pages
  • kdump_dump_non_private_cache
  • kdump_dump_private_cache
  • kdump_dump_user_data
  • kdump_dump_free_pages

And a sensible default could be used.

@pcahyna
Copy link
Member

pcahyna commented Nov 2, 2018

Without looking at the details, the proposal sounds reasonable. @baoquan-he what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants