Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag serialised client values #1117

Open
dhil opened this issue Mar 26, 2022 · 0 comments
Open

Tag serialised client values #1117

dhil opened this issue Mar 26, 2022 · 0 comments

Comments

@dhil
Copy link
Member

dhil commented Mar 26, 2022

In patch #1015 we added tags to server side values in order to make it easy to deserialise them on the client side. Currently, client side values are passed as serialised raw runtime objects to the server side during remote calls. As a consequence, the deserialisation on the server side uses a fair amount of guesswork and backtracking to deserialise a client side value.

To make server-side deserialisation easy, we should tag client side values too. There is an argument to be made, that we may want to keep objects tagged, currently, the client side performs tag erasure during deserialisation -- the cost of keeping objects tagged ought to be tiny on both the client and server side.

Related issues #219 and #1050.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant