Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimingKey Memory Leak #587

Open
zizhong opened this issue Apr 2, 2021 · 0 comments · Fixed by #588
Open

TimingKey Memory Leak #587

zizhong opened this issue Apr 2, 2021 · 0 comments · Fixed by #588
Assignees
@zizhong
Labels
bug For reporting bugs or issuing bug fixes

Comments

@zizhong
Copy link

zizhong commented Apr 2, 2021

Currently, TimingKey is implemented with a concurrent hashmap. TimingKey currently only provides registerKey to add an entry to the hashmap.
Each HTTPClient will create several different filters. Each filter will trigger registerKey several times.
There is no mechanism to reclaim the memory after the filters are unreachable.

If an app keeps creates new HTTPClients, the issue becomes more obvious.
zizhong pushed a commit to zizhong/rest.li that referenced this issue Apr 2, 2021
Fix TimingKey Memory Leak linkedin#587
7498a8c
@zizhong zizhong mentioned this issue Apr 2, 2021
Merged
zizhong pushed a commit to zizhong/rest.li that referenced this issue Apr 2, 2021
Fix TimingKey Memory Leak linkedin#587
8a3bd30
zizhong pushed a commit to zizhong/rest.li that referenced this issue Apr 12, 2021
Fix TimingKey Memory Leak linkedin#587
cf2a15c
zizhong pushed a commit to zizhong/rest.li that referenced this issue Apr 29, 2021
Fix TimingKey Memory Leak linkedin#587
da018d4
zizhong pushed a commit to zizhong/rest.li that referenced this issue May 3, 2021
Fix TimingKey Memory Leak linkedin#587
83bb325
nizarm pushed a commit that referenced this issue May 3, 2021
Fix TimingKey Memory Leak #587 (#588)
b4b6c5f
@zizhong zizhong self-assigned this May 3, 2021
@zizhong zizhong added the bug For reporting bugs or issuing bug fixes label May 3, 2021
@zizhong zizhong linked a pull request May 3, 2021 that will close this issue
Fix TimingKey Memory Leak #587 #588
Merged
lesterhaynes pushed a commit to lesterhaynes/rest.li that referenced this issue May 14, 2021
Fix TimingKey Memory Leak linkedin#587 (linkedin#588)
8f74cd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zizhong zizhong

Labels
bug For reporting bugs or issuing bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TimingKey Memory Leak #587 zizhong/rest.li
1 participant
@zizhong