Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burrow force GOMAXPROCS to be equal to runtime.NumCPU() #782

Open
dethi opened this issue Jun 7, 2023 · 2 comments · May be fixed by #821
Open

Burrow force GOMAXPROCS to be equal to runtime.NumCPU() #782

dethi opened this issue Jun 7, 2023 · 2 comments · May be fixed by #821

Comments

@dethi
Copy link

dethi commented Jun 7, 2023

When running Burrow on Kubernetes, we see a lot of CPU throttling during the initial startup. This happens because of the CPU limit we set on the container.

Two way to fix this:

  1. manually setting GOMAXPROCS environment variable to match the CPU limit
  2. auto-adjustment by looking at the cgroups. The most popular package to do that is: https://github.com/uber-go/automaxprocs

Unfortunately, Burrow force GOMAXPROCS to be equal to the number of CPU cores main.go#L71 (which in a container, is equal to the number of CPU cores of the host, not the container), so I can't set GOMAXPROCS manually.

  • Would you consider a PR that use automaxprocs?
  • Or at minimum a PR that add a configuration to disable main.go#L71?
@dethi
Copy link
Author

dethi commented Aug 24, 2023

@bai any thought?

@joseronierison
Copy link

👍

Currently we are setting the GOMAXPROCS manually, but it would be better to have a automatic configuration for that using the automaxprocs .

@dethi dethi linked a pull request Jul 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants