-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rules name refinement #1
Comments
Hello! I read the docs and TBH I'm not sure I understood what all the rules are about because the descriptions are sometimes quite short. It would be nice to explain in the readme (and also in the error messages), what the right approach is. anyways, here are some suggestions for naming:
thank you! 🙂 |
I like
i think let userName = user.name;
t`Hello {userName}`; I think identifier is more right word, or turn this upside-down |
|
Created a PR, changed named of rules which are have no doubts. Didn't change |
@vonovak I like your suggestion for rule names
What do you think? |
@igorDolzh you a bit late 😃 We already merged renaming for
I like this one. Sounds pretty self-describing.
I like |
how about renaming |
This issue for ongoing discussion for better name of the rules before it goes live.
missing-lingui-transformation
- i think "transformation" is not the right word. Also "lingui" is already in the rule id (as plugin namespacelingui/
, so should not be duplicated.unmarked-string
unwrapped-string
i18n-only-identifiers
- i don't like thei18n
in the name because it may confuse people that this rule is applicable toi18n
instance calls. But in fact it works fort
macro only.only-identifiers
Offer better naming for this rules, i don't really happy with what i'm came up.
The text was updated successfully, but these errors were encountered: