Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXME comment about mutate pass not being run #796

Open
waywardmonkeys opened this issue Dec 17, 2024 · 0 comments
Open

FIXME comment about mutate pass not being run #796

waywardmonkeys opened this issue Dec 17, 2024 · 0 comments
Labels
masonry Issues relating to the Masonry widget layer

Comments

@waywardmonkeys
Copy link
Contributor

In the Masonry calculator example, there is this bit of code:

            Update::HoveredChanged(true) => {
                ctx.mutate_later(&mut self.inner, move |mut inner| {
                    SizedBox::set_border(&mut inner, Color::WHITE, 3.0);
                });
                // FIXME - This is a monkey-patch for a problem where the mutate pass isn't run after this.
                // Should be fixed once the pass spec RFC is implemented.
                ctx.request_anim_frame();
            }

Is that FIXME still valid and if so, is there an issue tracking the missing functionality?

@waywardmonkeys waywardmonkeys added the masonry Issues relating to the Masonry widget layer label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
masonry Issues relating to the Masonry widget layer
Projects
None yet
Development

No branches or pull requests

1 participant