Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type check lightly.models #1392

Closed
philippmwirth opened this issue Sep 13, 2023 · 1 comment
Closed

Type check lightly.models #1392

philippmwirth opened this issue Sep 13, 2023 · 1 comment

Comments

@philippmwirth
Copy link
Contributor

Type check lightly.models

  • Work through the excluded files with prefix lightly.models and tests/models in mypy.ini and type check one by one.
  • Work through the excluded files with prefix lightly/models/heads and tests/models/heads in mypy.ini and type check one by one.
  • Remove follow_imports = skip for lightly.models.*.

Note: It's not necessary to type-check the following deprecated full implementations:

  • lightly.models.barlowtwins
  • lightly.models.byol
  • lightly.models.moco
  • lightly.models.nnclr
  • lightly.models.simclr
  • lightly.models.simsiam
@guarin guarin moved this to Todo in Type checking Sep 13, 2023
@guarin
Copy link
Contributor

guarin commented Aug 16, 2024

Closed in favor of #1635

@guarin guarin closed this as completed Aug 16, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Type checking Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Type checking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guarin @philippmwirth