Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable HAVE_NEON_INTRINSICS #215

Open
1bsyl opened this issue May 14, 2022 · 7 comments
Open

Re-enable HAVE_NEON_INTRINSICS #215

1bsyl opened this issue May 14, 2022 · 7 comments
Milestone

Comments

@1bsyl
Copy link
Contributor

1bsyl commented May 14, 2022

It seems to me ARM_NEON is working and could be re-activated:
https://github.com/libsdl-org/SDL_ttf/blob/main/SDL_ttf.c#L122

diff --git a/SDL_ttf.c b/SDL_ttf.c
index 8a4bb3d..68909ea 100644
--- a/SDL_ttf.c
+++ b/SDL_ttf.c
@@ -119,7 +119,7 @@ int TTF_SetScript(int script) /* hb_script_t */
 #endif
 
 /* Round glyph width to 16 bytes use NEON instructions */
-#if 0 /*defined(__ARM_NEON)*/
+#if defined(__ARM_NEON)
 #  define HAVE_NEON_INTRINSICS 1
 #endif
@sezero
Copy link
Contributor

sezero commented May 14, 2022

Does it build / work on windows versions too?

@1bsyl
Copy link
Contributor Author

1bsyl commented May 14, 2022

I haven't re-tried that, I think it did (window for window arm platform). never try compiling on windows for android.
I probably can double-check (later..)

@slouken
Copy link
Collaborator

slouken commented May 16, 2022

What testing have you done to verify it?

@1bsyl
Copy link
Contributor Author

1bsyl commented May 16, 2022

I haven't done more testing recently. (I'll try the window compilation more later).
I don't know why this is back-out.
I've using these neon intrinsic routines for years now on android without special crash about it

@1bsyl
Copy link
Contributor Author

1bsyl commented May 19, 2022

I have some trouble to try the ARM compilation of SDL_ttf on window.
I have no device, my Visual Studio is old (2017) and not configured for ARM.
Would be nice if someone with a setup ready could try it.

@sezero
Copy link
Contributor

sezero commented Jun 29, 2022

Is this planned for 2.20 ?

@slouken
Copy link
Collaborator

slouken commented Jun 29, 2022

Is this planned for 2.20 ?

No, nobody has a setup to test it, so it'll have to go in post-release.

@slouken slouken added this to the 3.0 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants