Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Librato::Client#metrics can't paginate, filter by tag or compose queries #98

Closed
hakanensari opened this issue Aug 14, 2014 · 3 comments
Closed

Comments

@hakanensari
Copy link

I came across this when wanting to build a composite query. Librato::Client#metrics currently doesn't allow to apply tags or compose. Pagination seems to be broken as well.

Also, the examples in the source code reference the deprecated method.

@nextmat
Copy link
Contributor

nextmat commented Aug 14, 2014

Thanks for the report. I've fixed the doc errors, it looks like when we refactored some of those methods for the name change we lost the ability to do passthrough for other api options. We'll restore that.

@nextmat
Copy link
Contributor

nextmat commented Aug 14, 2014

Oh, regarding pagination we don't auto-paginate any measurement fetches in the gem. We've discussed adding it in the past, implementing it in client code is pretty simple though.

Ultimately I'd like get_measurements to return a lazy-loading enumerator that does smart pagination as needed behind the scenes. We don't have that yet however.

@nextmat
Copy link
Contributor

nextmat commented Nov 6, 2014

Added get_composite in 1.5.0 to make fetching composite measurements easier (example at the bottom of this section in the README).

Follow #84 if you are interested in updates as we address auto-pagination.

@nextmat nextmat closed this as completed Nov 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants