From ed7df5a84e644aca434a7d9e12e1086c0a6c77a3 Mon Sep 17 00:00:00 2001 From: George Ogata Date: Mon, 10 Apr 2017 19:58:26 -0400 Subject: [PATCH] Access Faraday environment using `#[]` (#138) We're seeing `env` come through as a `Hash` rather than a `Faraday::Response` here. Faraday's middleware docs are poor, but it seems common to look up environment values using `[]` rather than relying on the methods of `Response`, presumably because this can happen. --- lib/librato/metrics/middleware/expects_status.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librato/metrics/middleware/expects_status.rb b/lib/librato/metrics/middleware/expects_status.rb index a75552d..e448889 100644 --- a/lib/librato/metrics/middleware/expects_status.rb +++ b/lib/librato/metrics/middleware/expects_status.rb @@ -24,12 +24,12 @@ def on_complete(env) def sanitize_request(env) { - status: env.status, - url: env.url.to_s, - user_agent: env.request_headers["User-Agent"], + status: env[:status], + url: env[:url].to_s, + user_agent: (env[:request_headers] || {})["User-Agent"], request_body: env[:request_body], - response_headers: env.response_headers, - response_body: env.body + response_headers: env[:response_headers], + response_body: env[:body] } end end