Hole Punching: Use node's addresses coherently

[burdiyan]

This issue is a more scoped subset of the problems described in #2965.

The hole punching code doesn't use the addresses from the Libp2p host. Instead it only uses the observed addresses from Identify, and the addresses of the network interfaces.

Actually the "server" and the "client" parts of hole punching don't use the same set of addresses, as seen in the following code fragments:

go-libp2p/p2p/protocol/holepunch/svc.go

Lines 279 to 307 in 921cc71

	func (s *Service) getPublicAddrs() []ma.Multiaddr {
	addrs := removeRelayAddrs(s.ids.OwnObservedAddrs())
	interfaceListenAddrs, err := s.host.Network().InterfaceListenAddresses()
	if err != nil {
	log.Debugf("failed to get to get InterfaceListenAddresses: %s", err)
	} else {
	addrs = append(addrs, interfaceListenAddrs...)
	}
	addrs = ma.Unique(addrs)
	publicAddrs := make([]ma.Multiaddr, 0, len(addrs))
	for _, addr := range addrs {
	if manet.IsPublicAddr(addr) {
	publicAddrs = append(publicAddrs, addr)
	}
	}
	return publicAddrs
	}
	// DirectConnect is only exposed for testing purposes.
	// TODO: find a solution for this.
	func (s *Service) DirectConnect(p peer.ID) error {
	<-s.hasPublicAddrsChan
	s.holePuncherMx.Lock()
	holePuncher := s.holePuncher
	s.holePuncherMx.Unlock()

go-libp2p/p2p/protocol/holepunch/holepuncher.go

Line 209 in 921cc71

obsAddrs := removeRelayAddrs(hp.ids.OwnObservedAddrs())

I suggest to use host.Addrs() directly in both places, as those includes all the possible addresses, including the ones provided by the custom AddrsFactory.

[sukunrt]

@burdiyan Can you check if #2979 fixes your problem?

[p-shahi]

@burdiyan please re-open if that didn't fix the problem