Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to check that src/Makefile.am is up to date #37

Open
eteq opened this issue Aug 29, 2016 · 2 comments
Open

Add script to check that src/Makefile.am is up to date #37

eteq opened this issue Aug 29, 2016 · 2 comments

Comments

@eteq
Copy link
Member

eteq commented Aug 29, 2016

As discussed in #35, there's currently no check that the src/Makefile.am is kept up-to-date if new files are added.

Probably the best/easiest thing (as suggested in #35 (comment)) is to write a script that checks this. This should also get run as part of the travis tests that run on new PR's to make sure they add anything that might be needed.

@rmathar
Copy link

rmathar commented Oct 1, 2019

One way is

  • move src/Makefile.am to src/Makefile.am.in
  • delete the multi-line assignment of liberfa_la_SOURCES in src/Makefile.am.in
  • add lines in configure.ac before the AC_CONFIG_FILES() with something
    that copies all c source files, excluding the test code:
    (cd Makefile ;
    cp Makefile.am.in Makefile.am ;
    echo liberfa_la_SOURCES = $(ls -w 4096 -t *.c *.h | grep -v t_erfa ) >> Makefile.am
    )

@eteq
Copy link
Member Author

eteq commented Oct 4, 2019

@rmathar - that sounds like a reasonable idea... would you like to make a PR that makes these changes? (since it's your idea that way you'd get credit for the commits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants