Response.GetCertInfos() is not const

[askraskr]

Description

Since Response.GetCertInfos() method is not const, we cannot use it with constant response objects.
for example, you we cannot pass a Response object to a function with the following signature:

nlohmann::json response_to_json(const cpr::Response &response)
{
   // .....
   for (size_t i{}; const auto &cert: response.GetCertInfos()) {
              // do something with cert
   }
   // .....
}

Example/How to Reproduce

nlohmann::json response_to_json(const cpr::Response &response)
{
   // .....
   for (size_t i{}; const auto &cert: response.GetCertInfos()) {
              // do something with cert
   }
   // .....
}

int main() 
{
        auto response = cpr::Get(cpr::Url("https://www.google.com"),
	                         cpr::UserAgent("Mozilla")
	);
        auto json = response_to_json(response);
}

Possible Fix

Since GetCertInfos() is not changing any data member of Response, it's better to make it const

namespace cpr {
///.... other stuff
class Response {
    ///.... other stuff
    std::vector<CertInfo> GetCertInfos() const;
    ///.... other stuff
};
} // namespace cpr

Where did you get it from?

Other (specify in "Additional Context/Your Environment")

Additional Context/Your Environment

• OS: All
• Version: Development

[COM8]

@askraskr thanks for reporting. Fixed in #1076.
Can you please confirm it works now for you?

[askraskr]

@COM8 Yes, it works.
thanks