From 29430aff3374801abec4719df48954938f09bfd8 Mon Sep 17 00:00:00 2001 From: evoskuil Date: Mon, 6 Feb 2023 20:13:19 -0800 Subject: [PATCH 1/2] Make settings virtual. --- include/bitcoin/protocol/settings.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/bitcoin/protocol/settings.hpp b/include/bitcoin/protocol/settings.hpp index 69284f8..d799c49 100644 --- a/include/bitcoin/protocol/settings.hpp +++ b/include/bitcoin/protocol/settings.hpp @@ -31,6 +31,8 @@ namespace protocol { /// Common protocol configuration settings, properties not thread safe. struct BCP_API settings { + DEFAULT_COPY_MOVE_DESTRUCT(settings); + settings() NOEXCEPT; settings(uint32_t send_high_water, uint32_t receive_high_water) NOEXCEPT; From 6b74037711623cfa9d94d1064a27275caed45e00 Mon Sep 17 00:00:00 2001 From: evoskuil Date: Wed, 22 Feb 2023 22:42:19 -0800 Subject: [PATCH 2/2] Remove dead test setup code. --- test/test.hpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/test.hpp b/test/test.hpp index 67f9daa..d2f3891 100644 --- a/test/test.hpp +++ b/test/test.hpp @@ -38,11 +38,6 @@ #define TEST_PATH \ TEST_DIRECTORY + "/" + TEST_NAME -#ifdef _MSC_VER - #define NO_GLOBAL_INIT_CALLS 26426 - #define NO_UNUSED_LOCAL_SMART_PTR 26414 -#endif - #ifdef _MSC_VER BC_DISABLE_WARNING(NO_ARRAY_INDEXING) BC_DISABLE_WARNING(NO_GLOBAL_INIT_CALLS)