Initial ZeroMQ Interface implementation. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now fully sync the headers, and get notified about new headers. Testing with: ./run_electrum --testnet -V i --oneserver The libbitcoin v4 testnet server is hardcoded in the Interface class for now. grep for "TODO: libbitcoin" for further work. Signed-off-by: parazyd <[email protected]>
Signed-off-by: parazyd <[email protected]>
Signed-off-by: parazyd <[email protected]>
Note that point[0] has changed. Review this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can fully sync the headers, and get notified about new headers.
Testing can be done with:
The libbitcoin v4 testnet server is hardcoded in the Interface class for now.
grep for
TODO: libbitcoinfor notable places in the code.This commit is relatively large, because changing the interface implies rewriting most of the interface.py module.
Additionally, this commit adds the zeromq.py module, which is the zmq client implementation that communicates with bs.
All locations where current and further code needs to be written, changed, and reviewed are marked with
TODO: libbitcoinfor easier navigation while working.
interface.py and zeromq.py also implement their own print debug functions that aren't connected to then internal Electrum
logging. This is done intentionally to make it more obvious when zmq-related functions are called.