Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ar discount renew #36

Merged
merged 4 commits into from
May 6, 2024
Merged

Feat/ar discount renew #36

merged 4 commits into from
May 6, 2024

Conversation

Th0rgal
Copy link
Member

@Th0rgal Th0rgal commented May 6, 2024

This closes #35

@Th0rgal Th0rgal requested a review from irisdv May 6, 2024 15:23
@Th0rgal Th0rgal self-assigned this May 6, 2024
@Th0rgal Th0rgal added the 🔥 Ready for review Pull Request needs a label May 6, 2024
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just left a small comment in one of the test

DummyAutoRenewal::TEST_CLASS_HASH, array![eth.contract_address.into()]
);

// we set the renewal contract and enable the discount
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we don't enable the discounts no ?

@Th0rgal Th0rgal merged commit 02d547b into master May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review Pull Request needs a
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add free renewal function for auto renewal
2 participants