Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CucumberPlugin.cucumber is an InputKey. #29

Open
Tillaert opened this issue Mar 23, 2017 · 6 comments
Open

CucumberPlugin.cucumber is an InputKey. #29

Tillaert opened this issue Mar 23, 2017 · 6 comments
Assignees
Labels

Comments

@Tillaert
Copy link

sbt prevents sequencing of InputKeys.

CucumberPlugin.cucumber is defined as an InputKey, because it can pass additional commandline parameters.

Would it be an improvement to have a TaskKey that runs all cucumber tests, and a separate InputKey to run specific tests/pass other parameters?

For example how there is a test TaskKey[Unit] and testOnly InputKey[Unit]

@lewismj
Copy link
Owner

lewismj commented Mar 24, 2017

Thanks, I will take a look over the next few days.
--Mike

@lewismj
Copy link
Owner

lewismj commented Mar 28, 2017

I will take a look at this, this evening.

@lewismj
Copy link
Owner

lewismj commented Mar 31, 2017

Still investigating, will setup a waffle board and bundle a few improvements into next release.

@lewismj lewismj added this to the 0.0.6 Cucumber Runner milestone Mar 31, 2017
@lewismj lewismj self-assigned this Mar 31, 2017
@lewismj
Copy link
Owner

lewismj commented Apr 2, 2017

Hi, I just did a re-write of the 'CucumberRunner'. If you run via the 'sbt test' then you don't need the plugin. The plugin is just used to provide a new command.

I can look into this issue, but I am wondering if the plugin is really necessary, i.e. how many people need a separate command 'sbt cucumber' vs just running via 'sbt test'.

My ex-firm use 'sbt cucumber', so I'll probably keep updating it. Will take a look shortly, delayed a bit with the runner re-write.

@grahambarrgraham
Copy link

grahambarrgraham commented Apr 28, 2017

We have a multi-module set-up, with a module containing our BDD tests in the main source tree, and some unit tests for that module in the test tree. So running sbt cucumber to run the BDD tests, and sbt test to run the unit tests (which test some aspects of the BDD code) works for us.

@lewismj
Copy link
Owner

lewismj commented Apr 28, 2017

Ok, I'll take another look at the plugin and tart it up a bit, may be a few days before I get chance (probably Monday).

@lewismj lewismj added ready and removed in progress labels Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants