-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No signcolumn refresh after nvim fixendofline adds newline #1023
Comments
I found a small bug which I fixed in c96e3cf but that shouldn't be related. Otherwise, it seems to work for me. Can you double check using |
@lewis6991, thanks! file.mov |
What you are showing in the video is different from the reproductions steps. If the file is committed without an EOF char, then gitsigns should not show a diff upon opening the file. Can you please update the reproduction steps with exact commands. Vscode is not relevant here. You can create a file without EOF using: echo -n 'hello\n'world' > file
git add file
git commit Also double check if you have a |
@lewis6991 Got it, thanks! I have updated the |
Works fine for me. Screen.Recording.2024-05-28.at.13.54.08.mov |
@lewis6991, interesting, thanks a lot for taking your time on this one! Will investigate deeper into my setup. |
Description
After a newline is added by the fixendofline (new)vim option triggered by saving the file, gitsigns does not update the signcolumn to indicate that change. Only after reopening the file, gitsigns highlight the change on the last line.
Neovim version
NVIM v0.10.0-dev-3097+g064f3e42e
Operating system and version
macOS 14
Expected behavior
Gitsigns does refresh signcolumn after fixendofline adds newline.
Actual behavior
Gitsigns does NOT refresh signcolumn after fixendofline adds newline.
Also, the
Gitsigns refresh
and evenGitsigns detach
+Gitsigns attach
do not refresh the signcolumn.Minimal config
Steps to reproduce
$ cd && mkdir gitsigns_test && cd gitsigns_test && git init
$ echo -n 'test' > file
$ git add . && git commit -m 'commit'
file
with nvim$ nvim --clean -u minimal_lua_path file
:w
in nvim and see that despite neovim adding newline (because of the fixendofline setting), gitsigns do not show any difference in the signcolumn.Gitsigns debug messages
No response
The text was updated successfully, but these errors were encountered: