Add publishing for the uberjar artifact #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves jar generation to the build directory instead of the project root Publishing uses the `ejml-one` artifact ID and sets the automatic module name to `ejml.all`
SamCarlberg
added a commit
to SamCarlberg/allwpilib
that referenced
this pull request
Dec 3, 2024
Single JAR means no split packages Depends on lessthanoptimal/ejml#203 and local EJML artifacts
|
Would ejml-unified be a better name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39 by providing a single uberjar with an automatic module name, which modular libraries and applications can safely consume. Modularizing each artifact would require changing package names, which would break existing users.
Publishing uses the
ejml-oneartifact ID using./gradlew :publishon the root project, and sets the automatic module name toejml.all.The uberjar artifact is named
ejml-one, sinceejml-allis already used by the depends-on-everything project. I don't know if changing the existingejml-allartifact to publish the uberjar would break users, so I erred on the side of caution here.