-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML exporter parts thumbnails cutoff #881
Comments
Hey nathaneltitane, could you upload the MPD file ? So I can see if I get the same result. |
any complex mpd would do. have you tried replicating it? what is your result? |
Have tried with the same settings as you specified and with MPD file for Lego set 7740 (complex) and the result had no issues. Have found the code for generating the HTML, but nothing is sticking out, as far i can see on Leocad version is 23.03 |
Hey nathaneltitane, I also found that some of my Thumbnails where not cropped correctly. It looks like there is an error, in the code where each Thumbnail is generated and cropped. The function for (lcVector3& Point : Points)
{
lcVector3 mod_point(-Point.y, -Point.x, -Point.z);
Point = lcProjectPoint(mod_point, ViewMatrix, ProjectionMatrix, Viewport);
ExtraPixels = qMax(ExtraPixels, -Point.x);
ExtraPixels = qMax(ExtraPixels, Point.x - ThumbnailSize);
ExtraPixels = qMax(ExtraPixels, -Point.y);
ExtraPixels = qMax(ExtraPixels, Point.y - ThumbnailSize);
} So if you have the possibility, could you try modify code in model.cpp, with the above code. The code is located in |
Describe the bug
The parts thumbnails that are generated are being cut off, thus not showing exactly which part to use.
To Reproduce
Steps to reproduce the behavior:
Open MPD model
Click on Export > HTML
Set arguments/settings
![image](https://private-user-images.githubusercontent.com/5674757/271684251-f6098888-f04f-4830-8873-f8f4ce45f497.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE5MjY1OTIsIm5iZiI6MTcyMTkyNjI5MiwicGF0aCI6Ii81Njc0NzU3LzI3MTY4NDI1MS1mNjA5ODg4OC1mMDRmLTQ4MzAtODg3My1mOGY0Y2U0NWY0OTcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjVUMTY1MTMyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmJhZDhiM2U4ZjA2YWIwY2QzZDQ2MDg3ZTJiODlkYmNmNDc4MjI2YjVhMDhhYjFhZGJhNTIxMTAxZmM5Mzg1MCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.DQ_aGvsPYgY9kdQvMquyVq7xNXIqUR7HK8avMD6FiSc)
See error:
Expected behavior
Thumbnails should be fully rendered and proper to distinguis exact parts to use - may also need part number descriptor by it or under? (new option?)
Screenshots
See above
Version (please complete the following information):
N.B. Akin to bug on parts list preview where a certain thumbnail size is also cut off.
EDIT:
Added ouptut as attachment for analysis:
duel.tar.gz
The text was updated successfully, but these errors were encountered: