-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need a material 3 version of FloatingActionButtonSpeedDial #190
Comments
Hi! Any chance you could also publish an alpha release for Classic Views? Thanks! |
Hi @daniele-athome, right now I can't release an alpha for the classic view, but you can try the m3 branch with the work in progress using jitpack: https://jitpack.io/#leinardi/FloatingActionButtonSpeedDial/m3-SNAPSHOT |
Thanks. I tried before, but it won't build :-( https://jitpack.io/com/github/leinardi/FloatingActionButtonSpeedDial/m3-2.0.0-alpha01-g149f241-1/build.log For the moment I've copied the project code as a module in my app. I'll follow the upgrades here and switch back to a normal dependency when it'll be ready. |
@leinardi The m3 alpha looks really nice, thanks! The only minor feedback I have is that it uses Icons.Default.*, which, according to some, should be avoided due to the size of the icon lib dependency. But maybe that's moot if your lib strips out unused resources beforehand? One other minor point -- you may want to choose a different maven coordinate for the m3 version, rather than just reving the major version. That way you can maintain both in parallel. Thanks again for the m3. Any idea when you'll move it to stable? |
Hi @stephentalley, thanks for the feedback, it's really appreciated 👍
Regarding the It's only the sample app that uses it.
I'm not sure, I frankly don't want to keep maintaining both versions. My plan is to release M3 as a new major version and stop supporting M2, similar to what I did with the migration from support library to androidx.
Currently I don't have a precise idea, I'm still collecting feedback. But, if you think that the current state is good enough, I may consider releasing an alpha version soon-ish. |
Step 1: Are you in the right place?
Step 2: Describe your environment
com.leinardi.android:speed-dial.compose:1.0.0-alpha04
any
any
Step 3: Describe the problem:
FloatingActionButtonSpeedDial doesn't conform to the newest Material 3 spec for Floating Action Buttons.
In particular, the new Material 3 style is to use rounded-square buttons:
It would also be nice to rely on the androidx.compose.material3.MaterialTheme that the rest of our app uses, rather than the androidx.compose.material.MaterialTheme used currently.
The text was updated successfully, but these errors were encountered: