Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying Clarity 3 contracts using platform.hiro.so fails #5983

Open
314159265359879 opened this issue Nov 20, 2024 · 9 comments
Open

Deploying Clarity 3 contracts using platform.hiro.so fails #5983

314159265359879 opened this issue Nov 20, 2024 · 9 comments
Assignees
Labels
area:api bug Functionality broken bug-p1 Critical functionality broken for many customers, with no clear workarounds

Comments

@314159265359879
Copy link
Contributor

314159265359879 commented Nov 20, 2024

I understand this as the issue

  • When a user deploys a contract with clarity 3 keywords in it
  • they expect it to get deployed as a clarity 3 contract
  • however the contract is deployed as a clarity 2 contract and then fails to deploy

From:
https://hiro-pbc.canny.io/hiro-platform/p/nakamoto-clarity-3

Image

What is needed to support this on our end.

Does anyone have an example of a contract with clarity 3 keywords?

@314159265359879 314159265359879 added enhancement enhancement-p1 Critical functionality needed by many users, with no clear alternatives labels Nov 20, 2024
Copy link

linear bot commented Nov 20, 2024

@markmhendrickson
Copy link
Collaborator

@leahjlou might you have some technical input here re: what's needed on our end given your involvement in this thread?

@314159265359879 this seems more like a bug than an enhancement per se (since we provide the expectation that Stacks contracts of all types can get deployed)?

@kyranjamie
Copy link
Collaborator

We need to upgrade to the latest version and accept a clarity version through our API. I can try taking this on as part of API work

@kyranjamie kyranjamie self-assigned this Nov 21, 2024
@314159265359879 314159265359879 added bug Functionality broken bug-p1 Critical functionality broken for many customers, with no clear workarounds area:api and removed enhancement-p1 Critical functionality needed by many users, with no clear alternatives enhancement labels Nov 21, 2024
@leahjlou
Copy link

I was thinking this issue was being tracked here but thinking through it now, I see that is slightly different task.

Please let me know if there's anything I can do to help out here.

Copy link
Collaborator

camerow commented Nov 21, 2024

@kyranjamie added this to the next cycle - unless you feel it deserves higher priority (or you @markmhendrickson)

@r0zar
Copy link

r0zar commented Nov 27, 2024

Looking forward to seeing a PR merged for this!

@314159265359879
Copy link
Contributor Author

@camerow, can you link the related PR to this once it is public?

@314159265359879
Copy link
Contributor Author

314159265359879 commented Dec 10, 2024

With the work needed for this, can this issue be addressed too?
#5931

Another developer was asking for it, it looks related to me. I think it makes sense to deploy contracts with the latest version of Clarity as a default?

The developer explained they need block-height to return the Stacks block height and with Clarity 2 that will return the tenure height instead.

@camerow
Copy link
Collaborator

camerow commented Dec 12, 2024

@314159265359879 I think that makes sense, @kyranjamie is going to be working on this I believe in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api bug Functionality broken bug-p1 Critical functionality broken for many customers, with no clear workarounds
Projects
None yet
Development

No branches or pull requests

6 participants