Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 429 error for "error while loading the data, try reloading the page". #186

Open
314159265359879 opened this issue May 20, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@314159265359879
Copy link

image
image

A user is experiencing this issue when they are signed in to lockstacks.com and looking at their pooling info. The error just pops into the screen from time to time.

image

@markmhendrickson markmhendrickson added bug Something isn't working bug-p2 Critical functionality broken for few users, with no clear workarounds labels May 20, 2024
@markmhendrickson
Copy link

@friedger any chance you'd could investigate this sometime soon? It's popping up for more users

@pete-watters
Copy link

@markmhendrickson looking at this console error and it's 429 rate limiting issues from the Hiro API.

So it seems like something we can't do much about for now and that the error message and advice is the best we can do without changing the UI to auto poll

@markmhendrickson
Copy link

I believe @friedger was going to improve the error message here at the very least, so users have a better sense of what's happening

@markmhendrickson markmhendrickson changed the title Loading issue: "error while loading the data, try reloading the page". Improve 429 error for "error while loading the data, try reloading the page". Jul 15, 2024
@markmhendrickson markmhendrickson added enhancement New feature or request enhancement-p2 Critical functionality needed by few users, with no clear alternatives and removed bug Something isn't working bug-p2 Critical functionality broken for few users, with no clear workarounds labels Jul 15, 2024
@alter-eggo
Copy link
Contributor

@friedger to avoid 429 hiro requests you need to add 'x-hiro-product': 'Leather' request header for hiro api requests, link to how we do it

also you prob need to add request queue for hiro requests (we use p-queue library), to limit requests made by the app to 300rpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Development

No branches or pull requests

5 participants