Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable - '1 resource selected' is shown when editing an individual resource #4649

Closed
pcenov opened this issue Aug 16, 2024 · 4 comments · Fixed by #4672
Closed

Unstable - '1 resource selected' is shown when editing an individual resource #4649

pcenov opened this issue Aug 16, 2024 · 4 comments · Fixed by #4672

Comments

@pcenov
Copy link
Member

pcenov commented Aug 16, 2024

Observed behavior

When I click the Options menu for a resource or a folder and I select any of the available individual editing options (other than Edit completion) then I can see the text '1 resource selected' under the title of the modal.

Expected behavior

That text should be displayed only when bulk editing resources/folders.

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel with all of the supported resources
  3. Click the Options button for a folder or a resource and select any of the available editing options such as 'Edit language' or 'Edit attribution'
  4. Observe the text '1 resource selected' under the title of the modal

Additional information

1-resource-selected.mp4

Console logs

no errors observed in the console

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Aug 16, 2024

@radinamatic

@akolson
Copy link
Member

akolson commented Aug 19, 2024

Tagging @jtamiace for thoughts on this. cc @marcellamaki

@jtamiace
Copy link
Member

Agreed on the above suggestion to remove the '1 resource selected' string for individual resource editing.

@radinamatic
Copy link
Member

Manual QA on the unstable branch confirms the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment