Skip to content
This repository has been archived by the owner on Sep 29, 2022. It is now read-only.

Post reviews on GoodReads #136

Open
teampolyglot opened this issue Jan 12, 2020 · 4 comments
Open

Post reviews on GoodReads #136

teampolyglot opened this issue Jan 12, 2020 · 4 comments

Comments

@teampolyglot
Copy link
Contributor

teampolyglot commented Jan 12, 2020

GoodReads allows users to post "General updates". Users can use that to post their learnawesome reviews to GoodReads (the way we do for Twitter) for more visibility.

API docs should be available here: https://www.goodreads.com/api

Using oauth gem: https://www.rubydoc.info/gems/oauth/0.5.4

@teampolyglot
Copy link
Contributor Author

teampolyglot commented Jan 13, 2020

Reviews now get posted to GoodReads. Some cases to think about:

  • Nothing gets posted if user simply marks an item as "Want to learn"
  • PostReviewToSocialMediaJob.perform does 3 tasks. Should be broken up in smaller methods
  • Review flow is less than ideal. For eg: Adding star rating and review notes does not change status from "Want to learn" to "Have learned".

@teampolyglot
Copy link
Contributor Author

GoodReads integration is now done via Auth0. See #104

@teampolyglot
Copy link
Contributor Author

A user complained that the default oauth scope allows the app to post on their GoodReads. We should figure out how to get an incremental permission only when users want to enable auto-posting.

@tejpochiraju
Copy link

Assuming this can be closed given #230

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants