Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(RingTheory/TensorProduct): split finite/free results into new files #18653

Closed
wants to merge 5 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Nov 5, 2024


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

PR summary 0fbdca76c7

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.TensorProduct.Basic 1039 903 -136 (-13.09%)
Mathlib.RingTheory.Localization.BaseChange 1055 979 -76 (-7.20%)
Mathlib.LinearAlgebra.TensorProduct.RightExactness 1044 989 -55 (-5.27%)
Mathlib.RingTheory.QuotSMulTop 1048 999 -49 (-4.68%)
Mathlib.LinearAlgebra.TensorProduct.Vanishing 1046 1038 -8 (-0.76%)
Import changes for all files
Files Import difference
4 files Mathlib.Algebra.Module.Bimodule Mathlib.RingTheory.IsTensorProduct Mathlib.LinearAlgebra.TensorProduct.Opposite Mathlib.RingTheory.TensorProduct.Basic
-136
Mathlib.Algebra.Category.AlgebraCat.Symmetric Mathlib.Algebra.Category.AlgebraCat.Monoidal -132
Mathlib.RingTheory.MatrixAlgebra -117
Mathlib.RingTheory.PolynomialAlgebra -78
Mathlib.RingTheory.Localization.BaseChange -76
Mathlib.RingTheory.TensorProduct.MvPolynomial -73
Mathlib.LinearAlgebra.TensorProduct.Graded.External Mathlib.LinearAlgebra.TensorProduct.Graded.Internal -64
Mathlib.LinearAlgebra.TensorProduct.RightExactness -55
Mathlib.RingTheory.QuotSMulTop -49
19 files Mathlib.Algebra.Category.ModuleCat.ChangeOfRings Mathlib.Algebra.Category.ModuleCat.Presheaf.Limits Mathlib.Algebra.Category.ModuleCat.Sheaf.Colimits Mathlib.Algebra.Category.ModuleCat.Sheaf Mathlib.Algebra.Category.ModuleCat.Sheaf.Free Mathlib.Algebra.Category.ModuleCat.Sheaf.ChangeOfRings Mathlib.Algebra.Category.ModuleCat.Sheaf.Limits Mathlib.Algebra.Category.ModuleCat.Sheaf.Generators Mathlib.Algebra.Category.ModuleCat.Sheaf.Abelian Mathlib.Algebra.Category.ModuleCat.Presheaf.Colimits Mathlib.Algebra.Category.ModuleCat.Presheaf Mathlib.Algebra.Category.ModuleCat.Presheaf.Sheafification Mathlib.Algebra.Category.ModuleCat.Presheaf.EpiMono Mathlib.Algebra.Category.ModuleCat.Presheaf.Abelian Mathlib.Algebra.Category.ModuleCat.Presheaf.Pushforward Mathlib.Algebra.Category.ModuleCat.Sheaf.PushforwardContinuous Mathlib.Algebra.Category.ModuleCat.Presheaf.Sheafify Mathlib.Algebra.Category.ModuleCat.Sheaf.Quasicoherent Mathlib.Algebra.Category.ModuleCat.Presheaf.ChangeOfRings
-45
Mathlib.Algebra.Category.ModuleCat.Presheaf.Monoidal -44
Mathlib.Algebra.Category.ModuleCat.Presheaf.Free -41
7 files Mathlib.RingTheory.Bialgebra.Hom Mathlib.RingTheory.Bialgebra.TensorProduct Mathlib.RingTheory.Bialgebra.Basic Mathlib.Algebra.Category.BialgebraCat.Basic Mathlib.RingTheory.HopfAlgebra Mathlib.RingTheory.Bialgebra.Equiv Mathlib.Algebra.Category.HopfAlgebraCat.Basic
-13
22 files Mathlib.Geometry.RingedSpace.PresheafedSpace.Gluing Mathlib.Geometry.Manifold.Sheaf.Basic Mathlib.Topology.Sheaves.SheafCondition.UniqueGluing Mathlib.RingTheory.EssentialFiniteness Mathlib.Topology.Sheaves.LocalPredicate Mathlib.Geometry.RingedSpace.OpenImmersion Mathlib.Geometry.RingedSpace.Basic Mathlib.Topology.Sheaves.SheafCondition.EqualizerProducts Mathlib.RingTheory.SurjectiveOnStalks Mathlib.Geometry.RingedSpace.SheafedSpace Mathlib.Topology.Sheaves.SheafOfFunctions Mathlib.Geometry.RingedSpace.LocallyRingedSpace Mathlib.Topology.Sheaves.LocallySurjective Mathlib.Geometry.RingedSpace.Stalks Mathlib.RingTheory.RingHomProperties Mathlib.Topology.Sheaves.Operations Mathlib.Algebra.Category.Ring.Constructions Mathlib.Topology.Sheaves.Skyscraper Mathlib.Topology.Sheaves.SheafCondition.PairwiseIntersections Mathlib.Topology.Sheaves.Sheafify Mathlib.Geometry.RingedSpace.LocallyRingedSpace.HasColimits Mathlib.Topology.Sheaves.Stalks
-10
Mathlib.LinearAlgebra.TensorProduct.Vanishing -8
Mathlib.Algebra.Category.ModuleCat.EnoughInjectives Mathlib.AlgebraicGeometry.ProjectiveSpectrum.StructureSheaf -7
8 files Mathlib.RingTheory.RingHom.FiniteType Mathlib.RingTheory.Localization.Finiteness Mathlib.RingTheory.RingHom.Finite Mathlib.RingTheory.FiniteStability Mathlib.RingTheory.RingHom.Locally Mathlib.RingTheory.LocalProperties.Reduced Mathlib.RingTheory.LocalProperties.Basic Mathlib.RingTheory.RingHom.Surjective
-4
76 files Mathlib.NumberTheory.NumberField.Discriminant.Defs Mathlib.RingTheory.FractionalIdeal.Norm Mathlib.NumberTheory.Cyclotomic.Rat Mathlib.RepresentationTheory.GroupCohomology.Hilbert90 Mathlib.FieldTheory.Finite.Trace Mathlib.NumberTheory.NumberField.Discriminant.Basic Mathlib.NumberTheory.Cyclotomic.Discriminant Mathlib.NumberTheory.GaussSum Mathlib.RingTheory.Localization.NormTrace Mathlib.NumberTheory.LSeries.DirichletContinuation Mathlib.NumberTheory.NumberField.FractionalIdeal Mathlib.RingTheory.Trace.Defs Mathlib.LinearAlgebra.PID Mathlib.NumberTheory.NumberField.Norm Mathlib.RingTheory.Trace.Basic Mathlib.NumberTheory.LSeries.ZMod Mathlib.NumberTheory.NumberField.EquivReindex Mathlib.RepresentationTheory.GroupCohomology.Resolution Mathlib.Algebra.Lie.Derivation.Killing Mathlib.NumberTheory.Cyclotomic.PrimitiveRoots Mathlib.Analysis.Fourier.ZMod Mathlib.NumberTheory.Cyclotomic.Three Mathlib.LinearAlgebra.Trace Mathlib.RingTheory.IntegralClosure.IntegralRestrict Mathlib.Algebra.Lie.TraceForm Mathlib.Algebra.Lie.Killing Mathlib.NumberTheory.Cyclotomic.Gal Mathlib.NumberTheory.NumberField.CanonicalEmbedding.FundamentalCone Mathlib.Algebra.Lie.Weights.Basic Mathlib.Algebra.Lie.Weights.RootSystem Mathlib.NumberTheory.Cyclotomic.Embeddings Mathlib.RepresentationTheory.Character Mathlib.RingTheory.DedekindDomain.IntegralClosure Mathlib.NumberTheory.FLT.Three Mathlib.NumberTheory.NumberField.CanonicalEmbedding.ConvexBody Mathlib.Algebra.Lie.Weights.Chain Mathlib.NumberTheory.NumberField.Units.Basic Mathlib.NumberTheory.DirichletCharacter.GaussSum Mathlib.NumberTheory.LSeries.QuadraticNonvanishing Mathlib.Tactic.NormNum.LegendreSymbol Mathlib.RingTheory.DedekindDomain.Different Mathlib.RingTheory.Discriminant Mathlib.NumberTheory.ClassNumber.Finite Mathlib.NumberTheory.LegendreSymbol.QuadraticChar.GaussSum Mathlib.NumberTheory.LegendreSymbol.JacobiSymbol Mathlib.NumberTheory.LegendreSymbol.AddCharacter Mathlib.NumberTheory.Cyclotomic.PID Mathlib.NumberTheory.JacobiSum.Basic Mathlib.NumberTheory.LegendreSymbol.QuadraticReciprocity Mathlib.NumberTheory.NumberField.Basic Mathlib.NumberTheory.NumberField.Units.DirichletTheorem Mathlib.NumberTheory.ClassNumber.FunctionField Mathlib.RepresentationTheory.GroupCohomology.Basic Mathlib.NumberTheory.NumberField.Units.Regulator Mathlib.RingTheory.Trace.Quotient Mathlib.NumberTheory.Cyclotomic.Basic Mathlib.Algebra.Lie.Weights.Killing Mathlib.RingTheory.Complex Mathlib.Algebra.Module.LinearMap.Polynomial Mathlib.RepresentationTheory.GroupCohomology.LowDegree Mathlib.RingTheory.LinearDisjoint Mathlib.RingTheory.Ideal.Norm Mathlib.RingTheory.LocalRing.Module Mathlib.NumberTheory.NumberField.House Mathlib.NumberTheory.NumberField.Embeddings Mathlib.Algebra.Lie.Weights.Cartan Mathlib.Analysis.SpecialFunctions.Complex.CircleAddChar Mathlib.Algebra.Lie.Rank Mathlib.NumberTheory.NumberField.ClassNumber Mathlib.Tactic Mathlib.Algebra.Lie.Weights.Linear Mathlib.RingTheory.NormTrace Mathlib.NumberTheory.NumberField.CanonicalEmbedding.Basic Mathlib.Algebra.Lie.CartanExists Mathlib.NumberTheory.FunctionField Mathlib.Algebra.DirectSum.LinearMap
1
Mathlib.RingTheory.TensorProduct.Free 955
Mathlib.RingTheory.TensorProduct.Finite 1026

Declarations diff

+ instFree
- instance (R A M : Type*)

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Mathlib/RingTheory/LinearDisjoint.lean Outdated Show resolved Hide resolved
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split looks good to me and everything builds so:

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Nov 5, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/TensorProduct): split finite/free results into new files [Merged by Bors] - chore(RingTheory/TensorProduct): split finite/free results into new files Nov 5, 2024
@mathlib-bors mathlib-bors bot closed this Nov 5, 2024
@mathlib-bors mathlib-bors bot deleted the jmc-tensor-finite branch November 5, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants