Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Algebra to keep inclusion map without commutes #18110

Open
Vierkantor opened this issue Oct 23, 2024 · 0 comments
Open

Generalize Algebra to keep inclusion map without commutes #18110

Vierkantor opened this issue Oct 23, 2024 · 0 comments

Comments

@Vierkantor
Copy link
Contributor

This was raised in the discussion of #18092 but has been around for a long time:

We currently have the Algebra R A typeclass for commutative algebras that carries an inclusion map algebraMap : R -> A. We can also express non-commutative algebras using a combination of other typeclasses, but then the inclusion becomes a derived definition (for example, as (· • 1)). For better defeqs, if not simply mirroring actual mathematical practice, we should instead have a typeclass for non-commutative algebras that carries the inclusion map.

And in turn we should try to generalize this to canonical inclusions of groups etc.

When this issue is resolved:, it should be possible to revert the following definitions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant